Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify AckSetTrackerImpl and make acks after shutdown not cause a permanent error #872

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

dpcollins-google
Copy link
Collaborator

Fixes #870 ☕️

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Sep 13, 2021
@dpcollins-google dpcollins-google added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2021
@dpcollins-google dpcollins-google merged commit 98ceff0 into master Sep 13, 2021
@dpcollins-google dpcollins-google deleted the fix-race-2 branch September 13, 2021 14:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition on partition assignment causing the Subscriber to fail
3 participants