Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove local copy of beam I/O now that it is merged to upstream #873

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Sep 13, 2021
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples/snapshot/pom.xml Outdated Show resolved Hide resolved
pubsublite-beam-io/README.md Outdated Show resolved Hide resolved
@dpcollins-google dpcollins-google added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 15, 2021
@dpcollins-google
Copy link
Collaborator Author

  • Please also remove pubsublite-beam-io from versions.txt.

Done

  • Is the PubsubLiteIO in Beam version 2.32.0 equivalent to version 0.19.5 here? If not, we may consider removing the files here after the next Beam release.

Version 2.33.0 will be equivalent, I'll add a DO_NOT_MERGE label for now.

  • Please also resolve the merge conflicts. Thank you!

Done

Done

@dpcollins-google dpcollins-google removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 22, 2021
@dpcollins-google dpcollins-google dismissed anguillanneuf’s stale review November 22, 2021 20:16

Implemented changes, reviewer on vacation.

@dpcollins-google dpcollins-google merged commit 0bd9d52 into main Nov 22, 2021
@dpcollins-google dpcollins-google deleted the remove-beam branch November 22, 2021 20:16
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 6, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [1.4.1](https://www.github.com/googleapis/java-pubsublite/compare/v1.4.0...v1.4.1) (2021-12-03)


### Bug Fixes

* remove local copy of beam I/O now that it is merged to upstream ([#873](https://www.github.com/googleapis/java-pubsublite/issues/873)) ([0bd9d52](https://www.github.com/googleapis/java-pubsublite/commit/0bd9d52e1da3029281f67e3e323e7fca890d2fee))


### Dependencies

* update beam.version to v2.34.0 ([#950](https://www.github.com/googleapis/java-pubsublite/issues/950)) ([527f77f](https://www.github.com/googleapis/java-pubsublite/commit/527f77fabc59c8b294e119d0d68384b47624f0b9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([#952](https://www.github.com/googleapis/java-pubsublite/issues/952)) ([41ebb30](https://www.github.com/googleapis/java-pubsublite/commit/41ebb30bbfc729f1df3b0dc189dd4823e0af7360))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#960](https://www.github.com/googleapis/java-pubsublite/issues/960)) ([9e46dbc](https://www.github.com/googleapis/java-pubsublite/commit/9e46dbc52085e0bbfa6c14d2d7892608a1d2fa7a))
* update dependency com.google.cloud:pubsublite-beam-io to v0.23.0 ([#951](https://www.github.com/googleapis/java-pubsublite/issues/951)) ([c62c79c](https://www.github.com/googleapis/java-pubsublite/commit/c62c79c21bca315740e9298e35a57e8ff08de4db))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants