Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify CommitterImpl to exit early in case of permanent failure #90

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Jun 2, 2020

This avoids waiting on its own actions to complete if one of the commit futures returned by abort() calls stopAsync on the committer.

…to avoid waiting on its own actions to complete.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #90 into master will increase coverage by 0.33%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
+ Coverage     59.78%   60.11%   +0.33%     
- Complexity      386      388       +2     
============================================
  Files            90       90              
  Lines          2044     2046       +2     
  Branches        170      170              
============================================
+ Hits           1222     1230       +8     
+ Misses          731      724       -7     
- Partials         91       92       +1     
Impacted Files Coverage Δ Complexity Δ
.../cloud/pubsublite/internal/wire/CommitterImpl.java 65.30% <66.66%> (-0.66%) 8.00 <0.00> (ø)
...oogle/cloud/pubsublite/internal/ExtractStatus.java 72.22% <0.00%> (+38.88%) 6.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd67e98...5693f87. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 8858d58 into master Jun 2, 2020
@dpcollins-google dpcollins-google deleted the fix-committer-2 branch June 2, 2020 13:31
@dpcollins-google dpcollins-google restored the fix-committer-2 branch June 9, 2020 14:12
@anguillanneuf anguillanneuf deleted the fix-committer-2 branch June 11, 2020 19:06
@dpcollins-google dpcollins-google restored the fix-committer-2 branch June 11, 2020 20:00
@chingor13 chingor13 deleted the fix-committer-2 branch April 15, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants