Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fail early when publishing to already failed publishers #934

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Nov 3, 2021

Also log a warning by default when a publisher client fails.

Also make dependencies.sh include googleapis/synthtool#1266

@dpcollins-google dpcollins-google requested a review from a team as a code owner November 3, 2021 14:08
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Nov 3, 2021
@dpcollins-google dpcollins-google requested a review from a team as a code owner November 3, 2021 14:18
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/dependencies.sh

@dpcollins-google dpcollins-google added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6ab2754 into main Nov 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the early-abort-publishes branch November 3, 2021 14:30
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 11, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.4.0](https://www.github.com/googleapis/java-pubsublite/compare/v1.3.0...v1.4.0) (2021-11-11)


### Features

* Introduce Native Image testing build script changes ([#924](https://www.github.com/googleapis/java-pubsublite/issues/924)) ([5801212](https://www.github.com/googleapis/java-pubsublite/commit/5801212edb94ceee10b344141d7c4b75cc07d51d))


### Bug Fixes

* Fail early when publishing to already failed publishers ([#934](https://www.github.com/googleapis/java-pubsublite/issues/934)) ([6ab2754](https://www.github.com/googleapis/java-pubsublite/commit/6ab2754292f34854f1fd68b513d7b71936f6e96e))


### Dependencies

* Bump assorted dependencies which need to be incremented together ([#943](https://www.github.com/googleapis/java-pubsublite/issues/943)) ([ab63bf2](https://www.github.com/googleapis/java-pubsublite/commit/ab63bf24addfb0b41e2a1c0cc4b5eafb126b0703))
* Correct BOM deps ([#946](https://www.github.com/googleapis/java-pubsublite/issues/946)) ([fa6bbbe](https://www.github.com/googleapis/java-pubsublite/commit/fa6bbbedda4f022e4246e602e20441559192c5ca))
* update beam.version to v2.33.0 ([#920](https://www.github.com/googleapis/java-pubsublite/issues/920)) ([91289d2](https://www.github.com/googleapis/java-pubsublite/commit/91289d2f9cd92a0af6bbdf5701dfd71c307275cb))
* update dependency com.google.auto.service:auto-service to v1.0.1 ([#935](https://www.github.com/googleapis/java-pubsublite/issues/935)) ([b72dcf6](https://www.github.com/googleapis/java-pubsublite/commit/b72dcf684e9a79e5699b34b314bbf4486a717292))
* update dependency com.google.auto.service:auto-service-annotations to v1.0.1 ([#936](https://www.github.com/googleapis/java-pubsublite/issues/936)) ([30b4ab0](https://www.github.com/googleapis/java-pubsublite/commit/30b4ab01357484d080b064d100b4590cd1ee4912))
* update dependency com.google.cloud:google-cloud-pubsub to v1.114.7 ([#926](https://www.github.com/googleapis/java-pubsublite/issues/926)) ([80becc5](https://www.github.com/googleapis/java-pubsublite/commit/80becc572b1769534c525e7962159045a3fc25d1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 ([#925](https://www.github.com/googleapis/java-pubsublite/issues/925)) ([50a36f3](https://www.github.com/googleapis/java-pubsublite/commit/50a36f3c30e7a1b66cb1ee3be7d5f7382e205fa4))
* update dependency com.google.cloud:pubsublite-beam-io to v0.22.0 ([#915](https://www.github.com/googleapis/java-pubsublite/issues/915)) ([b9f7727](https://www.github.com/googleapis/java-pubsublite/commit/b9f7727e2a507415a170f49d7c2947bac187addc))
* update dependency com.google.errorprone:error_prone_annotations to v2.10.0 ([#939](https://www.github.com/googleapis/java-pubsublite/issues/939)) ([eea5f38](https://www.github.com/googleapis/java-pubsublite/commit/eea5f381ffe065ccbfc6ba69207bd2ce170c6a9b))
* update dependency com.google.errorprone:error_prone_core to v2.10.0 ([#940](https://www.github.com/googleapis/java-pubsublite/issues/940)) ([c5359e8](https://www.github.com/googleapis/java-pubsublite/commit/c5359e875cd9dca8298c032d4a4814e5991d3830))
* update dependency com.google.flogger:flogger-system-backend to v0.7.1 ([#917](https://www.github.com/googleapis/java-pubsublite/issues/917)) ([580aa0a](https://www.github.com/googleapis/java-pubsublite/commit/580aa0acf5e53849d79f95239be944b5ac269461))
* update dependency org.checkerframework:checker-qual to v3.19.0 ([#933](https://www.github.com/googleapis/java-pubsublite/issues/933)) ([5b49749](https://www.github.com/googleapis/java-pubsublite/commit/5b49749be4b0858e7a8fbbe0524f17035fb2797e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants