Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Partition assignment stream does not require an initial response #966

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

tmdiep
Copy link
Collaborator

@tmdiep tmdiep commented Dec 7, 2021

If the client reconnects and assignments have not changed, the server does not send an initial assignment set. This can cause subscriber shutdown to hang because the lock is held in SingleConnection while waiting for stream initialization to complete.

@tmdiep tmdiep requested a review from a team as a code owner December 7, 2021 03:03
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 7, 2021
@dpcollins-google dpcollins-google merged commit 8227d31 into googleapis:main Dec 7, 2021
@tmdiep tmdiep deleted the assignment_stream branch December 7, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants