Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change PublisherImpl and SerialBatcher interplay to not call into the network layer on the downcall #975

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

dpcollins-google
Copy link
Collaborator

This call can cause user publish() calls to block until the stream is able to reconnect on transient stream disconnections

…o the network layer on the downcall

This call can cause user publish() calls to block until the stream is able to reconnect on transient stream disconnections
@dpcollins-google dpcollins-google requested a review from a team as a code owner December 8, 2021 19:22
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 8, 2021
@dpcollins-google dpcollins-google requested a review from a team as a code owner December 8, 2021 19:24
@dpcollins-google dpcollins-google merged commit e771c49 into main Dec 8, 2021
@dpcollins-google dpcollins-google deleted the no_publish_downcall branch December 8, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants