Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix packaging and dependency declarations #46

Merged
merged 4 commits into from Dec 24, 2019
Merged

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Dec 23, 2019

This artifact is not correctly declaring its dependencies.

@googlebot googlebot added the cla: yes label Dec 23, 2019
@chingor13 chingor13 changed the title deps: fix dependency declarations fix: fix packaging and dependency declarations Dec 24, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 24, 2019

Codecov Report

No coverage uploaded for pull request base (master@6859a77). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage          ?   87.14%           
  Complexity        ?      209           
=========================================
  Files             ?       11           
  Lines             ?      926           
  Branches          ?      100           
=========================================
  Hits              ?      807           
  Misses            ?       86           
  Partials          ?       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6859a77...876ebf8. Read the comment docs.

@chingor13 chingor13 requested review from codyoss and Dec 24, 2019
kolea2
kolea2 approved these changes Dec 24, 2019
@athakor athakor merged commit 2a7c613 into master Dec 24, 2019
13 checks passed
@athakor athakor deleted the fix-dependencies branch Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants