Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: easymock, objenesis, google-cloud-core are test deps #74

Merged
merged 1 commit into from Feb 4, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Feb 4, 2020

This is causing linkage errors as test dependencies are leaking into the compile dependencies.

@googlebot googlebot added the cla: yes label Feb 4, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 4, 2020

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage     87.14%   87.14%           
  Complexity      209      209           
=========================================
  Files            11       11           
  Lines           926      926           
  Branches        100      100           
=========================================
  Hits            807      807           
  Misses           86       86           
  Partials         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a421779...ba69218. Read the comment docs.

@chingor13 chingor13 requested a review from Feb 4, 2020
kolea2
kolea2 approved these changes Feb 4, 2020
@chingor13 chingor13 merged commit 6fea948 into master Feb 4, 2020
13 checks passed
@chingor13 chingor13 deleted the test-deps branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants