This repository was archived by the owner on Sep 16, 2023. It is now read-only.
docs(samples): adding client library samples - #242
Merged
Merged
Conversation
product-auto-label
Bot
added
api: security-privateca
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
google-cla
Bot
added
the
cla: yes
…/java-security-private-ca into client-samples-update � Conflicts: � samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate_CSR.java
sushantsikka
left a comment
sushantsikka
left a comment
There was a problem hiding this comment.
Hi Sita, thanks for working on this. Took a cursory look at the samples and have some minor suggestions for the code comments.
…/java-security-private-ca into client-samples-update � Conflicts: � samples/snippets/cloud-client/src/main/java/privateca/ActivateSubordinateCa.java
Contributor
Author
|
Thanks for the review @sushantsikka! PTAL |
Contributor
Author
|
Hi @chingor13! PTAL |
blunderbuss-gcf
Bot
removed
the
blunderbuss: assign
blunderbuss-gcf
Bot
removed
the
blunderbuss: assign
stephaniewang526
suggested changes
Aug 20, 2021
stephaniewang526
left a comment
stephaniewang526
left a comment
There was a problem hiding this comment.
Please update the initial commit as well as the PR subject to docs(samples): add ... samples. The reason is that feat: will automatically trigger a minor bump on the client library version which is undesirable in this case since we are just adding some samples.
stephaniewang526
suggested changes
Aug 20, 2021
stephaniewang526
left a comment
stephaniewang526
left a comment
There was a problem hiding this comment.
Please do not include README.md changes within this PR since they are not related to the samples -- let's revert them back.
Sita04
changed the title
Sita04
marked this pull request as draft
August 24, 2021 07:38
Sita04
marked this pull request as ready for review
August 24, 2021 08:48
stephaniewang526
approved these changes
Aug 27, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://www.github.com/googleapis/java-security-private-ca/compare/v2.0.2...v2.1.0) (2021-09-01) ### Features * Remove use of deprecated gradle command in java README ([#1196](https://www.github.com/googleapis/java-security-private-ca/issues/1196)) ([#258](https://www.github.com/googleapis/java-security-private-ca/issues/258)) ([b8b3f05](https://www.github.com/googleapis/java-security-private-ca/commit/b8b3f0500eaf6ca7d278157577bbc4354d0ed3af)) ### Documentation * **samples:** adding client library samples ([#242](https://www.github.com/googleapis/java-security-private-ca/issues/242)) ([7454cb0](https://www.github.com/googleapis/java-security-private-ca/commit/7454cb03c23bbf32a4afa4db9596a6a1f326de15)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([#260](https://www.github.com/googleapis/java-security-private-ca/issues/260)) ([cc44e1e](https://www.github.com/googleapis/java-security-private-ca/commit/cc44e1e10b47f3ca5cabdc375617399c4921c734)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following samples and tests: