Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

docs(samples): adding client library samples #242

Merged
merged 19 commits into from
Aug 27, 2021
Merged

docs(samples): adding client library samples #242

merged 19 commits into from
Aug 27, 2021

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Aug 11, 2021

Added the following samples and tests:

  1. Filtering certificates
  2. Undeleting Certificate Authority
  3. Creating Certificate with CSR
  4. Creating and activating Subordinate CA
  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label bot added api: security-privateca Issues related to the googleapis/java-security-private-ca API. samples Issues that are directly related to samples. labels Aug 11, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 11, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@Sita04 Sita04 requested a review from a team as a code owner August 11, 2021 13:47
sushantsikka
sushantsikka reviewed Aug 14, 2021
View reviewed changes
Copy link

@sushantsikka sushantsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sita, thanks for working on this. Took a cursory look at the samples and have some minor suggestions for the code comments.

samples/snippets/cloud-client/src/main/java/privateca/ActivateSubordinateCa.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/ActivateSubordinateCa.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate_CSR.java Outdated Show resolved Hide resolved
@Sita04
docs: lint fix
8d87187
@Sita04
Merge branch 'client-samples-update' of https://github.com/googleapis…
6534b87 
…/java-security-private-ca into client-samples-update

� Conflicts:
�	samples/snippets/cloud-client/src/main/java/privateca/ActivateSubordinateCa.java
@Sita04
Copy link
Contributor Author

Sita04 commented Aug 15, 2021

Thanks for the review @sushantsikka! PTAL

@Sita04
Copy link
Contributor Author

Sita04 commented Aug 16, 2021

Hi @chingor13! PTAL

@chingor13 chingor13 requested a review from a team August 18, 2021 21:49
@chingor13 chingor13 removed their assignment Aug 18, 2021
@chingor13 chingor13 added the blunderbuss: assign Instruct blunderbuss to assign someone label Aug 18, 2021
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Aug 18, 2021
@Sita04 Sita04 added the blunderbuss: assign Instruct blunderbuss to assign someone label Aug 18, 2021
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Aug 18, 2021
stephaniewang526
stephaniewang526 suggested changes Aug 20, 2021
View reviewed changes
Copy link

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the initial commit as well as the PR subject to docs(samples): add ... samples. The reason is that feat: will automatically trigger a minor bump on the client library version which is undesirable in this case since we are just adding some samples.

stephaniewang526
stephaniewang526 suggested changes Aug 20, 2021
View reviewed changes
Copy link

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not include README.md changes within this PR since they are not related to the samples -- let's revert them back.

@Sita04 Sita04 changed the title feat: adding client library samples docs(samples): adding client library samples Aug 23, 2021
@Sita04 Sita04 marked this pull request as draft August 24, 2021 07:38
@Sita04 Sita04 marked this pull request as ready for review August 24, 2021 08:48
@stephaniewang526 stephaniewang526 merged commit 7454cb0 into master Aug 27, 2021
@stephaniewang526 stephaniewang526 deleted the client-samples-update branch August 27, 2021 16:57
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 1, 2021
@release-please
chore: release 2.1.0 (#257)
e7e0ea2 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.1.0](https://www.github.com/googleapis/java-security-private-ca/compare/v2.0.2...v2.1.0) (2021-09-01)


### Features

* Remove use of deprecated gradle command in java README ([#1196](https://www.github.com/googleapis/java-security-private-ca/issues/1196)) ([#258](https://www.github.com/googleapis/java-security-private-ca/issues/258)) ([b8b3f05](https://www.github.com/googleapis/java-security-private-ca/commit/b8b3f0500eaf6ca7d278157577bbc4354d0ed3af))


### Documentation

* **samples:** adding client library samples  ([#242](https://www.github.com/googleapis/java-security-private-ca/issues/242)) ([7454cb0](https://www.github.com/googleapis/java-security-private-ca/commit/7454cb03c23bbf32a4afa4db9596a6a1f326de15))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([#260](https://www.github.com/googleapis/java-security-private-ca/issues/260)) ([cc44e1e](https://www.github.com/googleapis/java-security-private-ca/commit/cc44e1e10b47f3ca5cabdc375617399c4921c734))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sushantsikka sushantsikka sushantsikka left review comments

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees

@stephaniewang526 stephaniewang526

Labels
api: security-privateca Issues related to the googleapis/java-security-private-ca API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sita04 @stephaniewang526 @sushantsikka @chingor13