Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

docs(samples): added samples and tests for updating and monitoring CA - #274

Merged
Sita04 merged 6 commits into
masterfrom
code-samples-2
Sep 21, 2021
Merged

docs(samples): added samples and tests for updating and monitoring CA#274
Sita04 merged 6 commits into
masterfrom
code-samples-2

Conversation

@Sita04

@Sita04 Sita04 commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

Added samples and tests for:

  1. Updating CA
  2. Monitoring CA
  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@Sita04 Sita04 added cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. api: privateca Issues related to the Certificate Authority Service API. labels Sep 13, 2021
@Sita04
Sita04 requested review from a team September 13, 2021 11:29
@snippet-bot

snippet-bot Bot commented Sep 13, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: security-privateca Issues related to the googleapis/java-security-private-ca API. and removed api: privateca Issues related to the Certificate Authority Service API. labels Sep 13, 2021

@sushantsikka sushantsikka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Sita. Got a few nits for the code comments.

@Sita04
Sita04 merged commit f9aba8b into master Sep 21, 2021
@Sita04
Sita04 deleted the code-samples-2 branch September 21, 2021 08:04
gcf-merge-on-green Bot pushed a commit that referenced this pull request Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: security-privateca Issues related to the googleapis/java-security-private-ca API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants