Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update java samples to v1 #274

Merged
merged 3 commits into from Feb 10, 2021

Conversation

katiehochberg
Copy link
Contributor

@katiehochberg katiehochberg commented Jan 12, 2021

As our GA date approaches, we want the samples in our docs to use the v1 version of our API rather than the v1beta1 version.

Example here: https://cloud.google.com/service-directory/docs/configuring-service-directory#servicedirectory_create_namespace-java

@katiehochberg katiehochberg requested a review from Jan 12, 2021
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@product-auto-label product-auto-label bot added api: servicedirectory samples labels Jan 12, 2021
@codecov
Copy link

@codecov codecov bot commented Jan 12, 2021

Codecov Report

Merging #274 (9668fd5) into master (91f839a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #274   +/-   ##
=========================================
  Coverage     78.90%   78.90%           
  Complexity      342      342           
=========================================
  Files            24       24           
  Lines          2380     2380           
  Branches         22       22           
=========================================
  Hits           1878     1878           
  Misses          456      456           
  Partials         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f839a...9668fd5. Read the comment docs.

@katiehochberg katiehochberg changed the title Update java samples to v1 feat: update java samples to v1 Jan 14, 2021
@eaball35 eaball35 added the kokoro:force-run label Feb 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 10, 2021
@eaball35 eaball35 added the automerge label Feb 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit b3c0230 into googleapis:master Feb 10, 2021
19 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: servicedirectory cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants