Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: downgrade protobuf to 3.17.3 (not the latest 3.18.0) #476

Merged
merged 2 commits into from Sep 21, 2021

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Sep 21, 2021

@Neenu1995 This version is the same as the version in the last release of the shared-dependencies BOM.

https://search.maven.org/artifact/com.google.cloud/first-party-dependencies/2.2.1/pom

@suztomo suztomo requested a review from as a code owner Sep 21, 2021
@google-cla google-cla bot added the cla: yes label Sep 21, 2021
@suztomo
Copy link
Member Author

@suztomo suztomo commented Sep 21, 2021

Simply downgrading it failed the check:

Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.protobuf:protobuf-java-util:3.17.3 paths to dependency are:
+-com.google.cloud:google-cloud-bigquery:2.1.10-SNAPSHOT
  +-com.google.cloud:google-cloud-core:2.1.4
    +-com.google.protobuf:protobuf-java-util:3.17.3 (managed) <-- com.google.protobuf:protobuf-java-util:3.18.0
...

https://github.com/googleapis/java-shared-dependencies/pull/476/checks?check_run_id=3668210382

@suztomo suztomo changed the title deps: protobuf 3.17.3 before the latest 3.18.0 deps: downgrade protobuf to 3.17.3 (not the latest 3.18.0) Sep 21, 2021
<google.api-common.version>2.0.2</google.api-common.version>
<google.common-protos.version>2.5.0</google.common-protos.version>
<google.core.version>2.1.4</google.core.version>
<google.core.version>2.1.3</google.core.version>
Copy link
Member Author

@suztomo suztomo Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google-cloud-core already depends on protobuf 3.18.0. Thus I needed to downgrade this too.

Neenu1995
Neenu1995 previously approved these changes Sep 21, 2021
@Neenu1995 Neenu1995 self-requested a review Sep 21, 2021
@Neenu1995 Neenu1995 dismissed their stale review Sep 21, 2021

Need to sort out the next core release before we merge this.

@Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Sep 21, 2021

Downgrading protobuf to 3.17.3 in java-core to avoid conflicts.
googleapis/java-core#562

@Neenu1995 Neenu1995 added the automerge label Sep 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e207c81 into googleapis:master Sep 21, 2021
23 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Sep 21, 2021
@suztomo suztomo deleted the downgrade_protobuf branch Sep 21, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 22, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.3.0](https://www.github.com/googleapis/java-shared-dependencies/compare/2.2.1...v2.3.0) (2021-09-22)


### Dependencies

* keep protobuf at 3.17.3 (not the latest 3.18.0) ([#476](https://www.github.com/googleapis/java-shared-dependencies/issues/476)) ([e207c81](https://www.github.com/googleapis/java-shared-dependencies/commit/e207c818f220967e3618d7a9d36f2cf26c07892e))
* update gax.version to v2.5.0 ([#479](https://www.github.com/googleapis/java-shared-dependencies/issues/479)) ([e22e62a](https://www.github.com/googleapis/java-shared-dependencies/commit/e22e62a3b248023ae94da2a02ec50006377a5157))
* update google.core.version to v2.1.4 ([#473](https://www.github.com/googleapis/java-shared-dependencies/issues/473)) ([116f278](https://www.github.com/googleapis/java-shared-dependencies/commit/116f2783dfc18f215905ceaff9f85f331f83472b))
* update google.core.version to v2.1.6 ([#478](https://www.github.com/googleapis/java-shared-dependencies/issues/478)) ([9e09728](https://www.github.com/googleapis/java-shared-dependencies/commit/9e0972834764b25e5e194e0e805efc5453120df3))
* update iam.version to v1.1.1 ([#470](https://www.github.com/googleapis/java-shared-dependencies/issues/470)) ([3b6e960](https://www.github.com/googleapis/java-shared-dependencies/commit/3b6e96050af8d976a30165481d764d8226143a39))
* update iam.version to v1.1.2 ([#472](https://www.github.com/googleapis/java-shared-dependencies/issues/472)) ([85329cc](https://www.github.com/googleapis/java-shared-dependencies/commit/85329cc6c13d16fe2eeeb076959ee16a752c1f9e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo added a commit to suztomo/java-shared-dependencies that referenced this issue Mar 17, 2022
suztomo pushed a commit to suztomo/java-shared-dependencies that referenced this issue Mar 17, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [2.3.0](https://www.github.com/googleapis/java-shared-dependencies/compare/2.2.1...v2.3.0) (2021-09-22)


### Dependencies

* keep protobuf at 3.17.3 (not the latest 3.18.0) ([googleapis#476](https://www.github.com/googleapis/java-shared-dependencies/issues/476)) ([e207c81](https://www.github.com/googleapis/java-shared-dependencies/commit/e207c818f220967e3618d7a9d36f2cf26c07892e))
* update gax.version to v2.5.0 ([googleapis#479](https://www.github.com/googleapis/java-shared-dependencies/issues/479)) ([e22e62a](https://www.github.com/googleapis/java-shared-dependencies/commit/e22e62a3b248023ae94da2a02ec50006377a5157))
* update google.core.version to v2.1.4 ([googleapis#473](https://www.github.com/googleapis/java-shared-dependencies/issues/473)) ([116f278](https://www.github.com/googleapis/java-shared-dependencies/commit/116f2783dfc18f215905ceaff9f85f331f83472b))
* update google.core.version to v2.1.6 ([googleapis#478](https://www.github.com/googleapis/java-shared-dependencies/issues/478)) ([9e09728](https://www.github.com/googleapis/java-shared-dependencies/commit/9e0972834764b25e5e194e0e805efc5453120df3))
* update iam.version to v1.1.1 ([googleapis#470](https://www.github.com/googleapis/java-shared-dependencies/issues/470)) ([3b6e960](https://www.github.com/googleapis/java-shared-dependencies/commit/3b6e96050af8d976a30165481d764d8226143a39))
* update iam.version to v1.1.2 ([googleapis#472](https://www.github.com/googleapis/java-shared-dependencies/issues/472)) ([85329cc](https://www.github.com/googleapis/java-shared-dependencies/commit/85329cc6c13d16fe2eeeb076959ee16a752c1f9e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants