Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner.it.ITSpannerOptionsTest: testMultipleSpannersFromSameSpannerOptions failed #146

Closed
flaky-bot bot opened this issue Apr 13, 2020 · 4 comments · Fixed by #153 or #161
Closed

spanner.it.ITSpannerOptionsTest: testMultipleSpannersFromSameSpannerOptions failed #146

flaky-bot bot opened this issue Apr 13, 2020 · 4 comments · Fixed by #153 or #161
Assignees
Labels
api: spanner priority: p1 type: bug

Comments

@flaky-bot
Copy link

@flaky-bot flaky-bot bot commented Apr 13, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.


commit: c8be7b5
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added priority: p1 type: bug buildcop: issue labels Apr 13, 2020
@product-auto-label product-auto-label bot added the api: spanner label Apr 13, 2020
@olavloite olavloite self-assigned this Apr 15, 2020
olavloite added a commit that referenced this issue Apr 15, 2020
The test should check for at most baseThreadCount instead of equality,
as it is possible that the thread pool shuts down one or more of its
threads temporarily.

Fixes #146
@flaky-bot
Copy link
Author

@flaky-bot flaky-bot bot commented Apr 15, 2020

Test passed for commit 3fe3ae0 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Apr 15, 2020
@flaky-bot flaky-bot bot reopened this Apr 16, 2020
olavloite added a commit that referenced this issue Apr 16, 2020
The test should check for at most baseThreadCount instead of equality,
as it is possible that the thread pool shuts down one or more of its
threads temporarily.

Fixes #146
@sid-dinesh94
Copy link

@sid-dinesh94 sid-dinesh94 commented Apr 20, 2020

I might have misread the above commit, but it seems to me that that the Sponge error filed by the BuildCop was telling us that the test expected 7 but actually found 8 opened Spanner's with the same name.
How did your commit which checks that the number of Spanner's with the same name (which was 8) is at most the number of baseThreadCount (7) , fix the issue?

Since the number of Spanner's with the same name would still be 8 but is not at most 7 (from baseThreadCount).

olavloite added a commit that referenced this issue Apr 21, 2020
The flaky test failure was caused by a lower number of base threads
being calculated before the test started, and not by an unexpected
drop in the number of threads after the test. This is now mitigated by
waiting for the initialization to finish before starting the test.

Fixes #146
@olavloite
Copy link
Contributor

@olavloite olavloite commented Apr 21, 2020

@sid-dinesh94 You're right, this flaky failure isn't caused by a drop in the number of threads after the test, but in a lower than expected read of the base thread count before the test. This is probably caused by a slow startup on a CI environment. I'm not able to reproduce it locally, but I've added an additional wait condition before the test to try to prevent these failures.

olavloite added a commit that referenced this issue Apr 21, 2020
The flaky test failure was caused by a lower number of base threads
being calculated before the test started, and not by an unexpected
drop in the number of threads after the test. This is now mitigated by
waiting for the initialization to finish before starting the test.

Fixes #146
@sid-dinesh94
Copy link

@sid-dinesh94 sid-dinesh94 commented Apr 21, 2020

Thanks for this, @olavloite
I've verified this works.

gcf-merge-on-green bot pushed a commit that referenced this issue Apr 22, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.53.0](https://www.github.com/googleapis/java-spanner/compare/v1.52.0...v1.53.0) (2020-04-22)


### Features

* optimize maintainer to let sessions be GC'ed instead of deleted ([#135](https://www.github.com/googleapis/java-spanner/issues/135)) ([d65747c](https://www.github.com/googleapis/java-spanner/commit/d65747cbc704508f6f1bcef6eea53aa411d42ee2))


### Bug Fixes

* assign unique id's per test case ([#129](https://www.github.com/googleapis/java-spanner/issues/129)) ([a553b6d](https://www.github.com/googleapis/java-spanner/commit/a553b6d48c4f5ee2d0583e5b825d73a85f06216e))
* check for not null input for Id classes ([#159](https://www.github.com/googleapis/java-spanner/issues/159)) ([ecf5826](https://www.github.com/googleapis/java-spanner/commit/ecf582670818f32e85f534ec400d0b8d31cf9ca6)), closes [#145](https://www.github.com/googleapis/java-spanner/issues/145)
* clean up test instance if creation failed ([#162](https://www.github.com/googleapis/java-spanner/issues/162)) ([ff571e1](https://www.github.com/googleapis/java-spanner/commit/ff571e16a45fbce692d9bb172749ff15fafe7a9c))
* fix flaky test and remove warnings ([#153](https://www.github.com/googleapis/java-spanner/issues/153)) ([d534e35](https://www.github.com/googleapis/java-spanner/commit/d534e350346b0c9ab8057ede36bc3aac473c0b06)), closes [#146](https://www.github.com/googleapis/java-spanner/issues/146)
* increase test timeout and remove warnings ([#160](https://www.github.com/googleapis/java-spanner/issues/160)) ([63a6bd8](https://www.github.com/googleapis/java-spanner/commit/63a6bd8be08a56d002f58bc2cdb2856ad0dc5fa3)), closes [#158](https://www.github.com/googleapis/java-spanner/issues/158)
* retry non-idempotent long-running RPCs ([#141](https://www.github.com/googleapis/java-spanner/issues/141)) ([4669c02](https://www.github.com/googleapis/java-spanner/commit/4669c02a24e0f7b1d53c9edf5ab7b146b4116960))
* retry restore if blocked by pending restore ([#119](https://www.github.com/googleapis/java-spanner/issues/119)) ([220653d](https://www.github.com/googleapis/java-spanner/commit/220653d8e25c518d0df447bf777a7fcbf04a01ca)), closes [#118](https://www.github.com/googleapis/java-spanner/issues/118)
* StatementParser did not accept multiple query hints ([#170](https://www.github.com/googleapis/java-spanner/issues/170)) ([ef41a6e](https://www.github.com/googleapis/java-spanner/commit/ef41a6e503f218c00c16914aa9c1433d9b26db13)), closes [#163](https://www.github.com/googleapis/java-spanner/issues/163)
* wait for initialization to finish before test ([#161](https://www.github.com/googleapis/java-spanner/issues/161)) ([fe434ff](https://www.github.com/googleapis/java-spanner/commit/fe434ff7068b4b618e70379c224e1c5ab88f6ba1)), closes [#146](https://www.github.com/googleapis/java-spanner/issues/146)


### Performance Improvements

* increase sessions in the pool in batches ([#134](https://www.github.com/googleapis/java-spanner/issues/134)) ([9e5a1cd](https://www.github.com/googleapis/java-spanner/commit/9e5a1cdaacf71147b67681861f063c3276705f44))
* prepare sessions with r/w tx in-process ([#152](https://www.github.com/googleapis/java-spanner/issues/152)) ([2db27ce](https://www.github.com/googleapis/java-spanner/commit/2db27ce048efafaa3c28b097de33518747011465)), closes [#151](https://www.github.com/googleapis/java-spanner/issues/151)


### Dependencies

* update core dependencies ([#109](https://www.github.com/googleapis/java-spanner/issues/109)) ([5753f1f](https://www.github.com/googleapis/java-spanner/commit/5753f1f4fed83df87262404f7a7ba7eedcd366cb))
* update core dependencies ([#132](https://www.github.com/googleapis/java-spanner/issues/132)) ([77c1558](https://www.github.com/googleapis/java-spanner/commit/77c1558652ee00e529674ac3a2dcf3210ef049fa))
* update dependency com.google.api:api-common to v1.9.0 ([#127](https://www.github.com/googleapis/java-spanner/issues/127)) ([b2c744f](https://www.github.com/googleapis/java-spanner/commit/b2c744f01a4d5a8981df5ff900f3536c83265a61))
* update dependency com.google.guava:guava-bom to v29 ([#147](https://www.github.com/googleapis/java-spanner/issues/147)) ([3fe3ae0](https://www.github.com/googleapis/java-spanner/commit/3fe3ae02376af552564c93c766f562d6454b7ac1))
* update dependency io.grpc:grpc-bom to v1.29.0 ([#164](https://www.github.com/googleapis/java-spanner/issues/164)) ([2d2ce5c](https://www.github.com/googleapis/java-spanner/commit/2d2ce5ce4dc8f410ec671e542e144d47f39ab40b))
* update dependency org.threeten:threetenbp to v1.4.3 ([#120](https://www.github.com/googleapis/java-spanner/issues/120)) ([49d1abc](https://www.github.com/googleapis/java-spanner/commit/49d1abcb6c9c48762dcf0fe1466ab107bf67146b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner priority: p1 type: bug
Projects
None yet
2 participants