spanner.it.ITSpannerOptionsTest: testMultipleSpannersFromSameSpannerOptions failed

[flaky-bot]

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

---

commit: c8be7b5
buildURL: Build Status, Sponge
status: failed

[flaky-bot]

Test passed for commit 3fe3ae0 (Build Status, Sponge)! Closing this issue.

[sid-dinesh94]

I might have misread the above commit, but it seems to me that that the Sponge error filed by the BuildCop was telling us that the test expected 7 but actually found 8 opened Spanner's with the same name.
How did your commit which checks that the number of Spanner's with the same name (which was 8) is at most the number of baseThreadCount (7) , fix the issue?

Since the number of Spanner's with the same name would still be 8 but is not at most 7 (from baseThreadCount).

[olavloite]

@sid-dinesh94 You're right, this flaky failure isn't caused by a drop in the number of threads after the test, but in a lower than expected read of the base thread count before the test. This is probably caused by a slow startup on a CI environment. I'm not able to reproduce it locally, but I've added an additional wait condition before the test to try to prevent these failures.