Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITCommitTimestampTest.invalidColumnOptionValue check very specific error message #175

Closed
skuruppu opened this issue Apr 23, 2020 · 0 comments · Fixed by #183
Closed

ITCommitTimestampTest.invalidColumnOptionValue check very specific error message #175

skuruppu opened this issue Apr 23, 2020 · 0 comments · Fixed by #183
Assignees
Labels
api: spanner priority: p2 type: bug

Comments

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Apr 23, 2020

The Spanner team reported that checking for specific error strings are error-prone as the returned string can change without notice.

I think they're specifically referring to this line:

expectedException.expectMessage("Errors parsing Spanner DDL statement");

If this can be fixed, that would be great.

@skuruppu skuruppu added priority: p2 type: bug api: spanner labels Apr 23, 2020
olavloite added a commit that referenced this issue Apr 25, 2020
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
olavloite added a commit that referenced this issue Apr 28, 2020
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
olavloite added a commit that referenced this issue Apr 29, 2020
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner priority: p2 type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants