Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add backup support #100

Merged
merged 28 commits into from Mar 19, 2020
Merged

feat: add backup support #100

merged 28 commits into from Mar 19, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Mar 13, 2020

Adds support for creating and managing backups and restoring databases from backups.

@olavloite olavloite added the api: spanner label Mar 13, 2020
@googlebot googlebot added the cla: yes label Mar 13, 2020
@olavloite olavloite added the kokoro:force-run label Mar 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 13, 2020
@olavloite olavloite added the kokoro:force-run label Mar 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 13, 2020
@olavloite olavloite added the kokoro:force-run label Mar 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 13, 2020
@olavloite olavloite requested review from skuruppu and chingor13 Mar 13, 2020
@olavloite olavloite added the kokoro:force-run label Mar 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 13, 2020
@olavloite olavloite added the kokoro:force-run label Mar 14, 2020
@olavloite olavloite requested review from hengfengli and removed request for chingor13 Mar 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 14, 2020
skuruppu
skuruppu approved these changes Mar 18, 2020
View changes
Copy link
Contributor

@skuruppu skuruppu left a comment

Just did a quick review since we already reviewed this PR earlier.

google-cloud-spanner/src/test/java/com/google/cloud/spanner/ParallelIntegrationTest.java Outdated
@@ -0,0 +1,20 @@
/*
* Copyright 2017 Google LLC
Copy link
Contributor

@skuruppu skuruppu Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2020

hengfengli
hengfengli approved these changes Mar 18, 2020
View changes
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM 👍

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@olavloite olavloite added the kokoro:force-run label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@olavloite olavloite added the kokoro:force-run label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@olavloite olavloite added the kokoro:force-run label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@olavloite olavloite added the kokoro:force-run label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@olavloite olavloite added the kokoro:force-run label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@olavloite olavloite added the kokoro:force-run label Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 19, 2020
@olavloite olavloite added the kokoro:force-run label Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 19, 2020
@olavloite olavloite added the kokoro:force-run label Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 19, 2020
@olavloite olavloite added the kokoro:force-run label Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 19, 2020
@olavloite olavloite added the kokoro:force-run label Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 19, 2020
@olavloite olavloite merged commit ed3874a into master Mar 19, 2020
12 of 13 checks passed
@olavloite olavloite deleted the backups branch Mar 19, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 20, 2020
@release-please
chore: release 1.52.0 (#110)
1d3c4ac 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.52.0](https://www.github.com/googleapis/java-spanner/compare/v1.51.0...v1.52.0) (2020-03-20)


### Features

* add backup support ([#100](https://www.github.com/googleapis/java-spanner/issues/100)) ([ed3874a](https://www.github.com/googleapis/java-spanner/commit/ed3874afcf55fe7381354e03dab3a3b97d7eb520))
* add Backups protos and APIs ([#97](https://www.github.com/googleapis/java-spanner/issues/97)) ([5643c22](https://www.github.com/googleapis/java-spanner/commit/5643c22a4531dac75b9fac5b128eb714a27920a0))


### Bug Fixes

* add client id to metrics to avoid collisions ([#117](https://www.github.com/googleapis/java-spanner/issues/117)) ([338e136](https://www.github.com/googleapis/java-spanner/commit/338e136508edc6745f9371e8a5d66638021bc8d7)), closes [#106](https://www.github.com/googleapis/java-spanner/issues/106)
* ignore added interface methods for generated code ([#101](https://www.github.com/googleapis/java-spanner/issues/101)) ([402cfa1](https://www.github.com/googleapis/java-spanner/commit/402cfa1e1e2994f7bb1b783cf823021b54fb175e)), closes [#99](https://www.github.com/googleapis/java-spanner/issues/99)
* use grpc 1.27.2 to prevent version conflicts ([#105](https://www.github.com/googleapis/java-spanner/issues/105)) ([37b7c88](https://www.github.com/googleapis/java-spanner/commit/37b7c8859e5f35d85bd14ef72662614fd185c020))


### Dependencies

* update core dependencies ([#94](https://www.github.com/googleapis/java-spanner/issues/94)) ([f3ca4c9](https://www.github.com/googleapis/java-spanner/commit/f3ca4c99c3d54f64c5eda11e4a4c076140fdbc6a))
* update opencensus.version to v0.26.0 ([#116](https://www.github.com/googleapis/java-spanner/issues/116)) ([1b8db0b](https://www.github.com/googleapis/java-spanner/commit/1b8db0b407429e02bb1e4c9af839afeed21dac5d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this issue Mar 25, 2020
@yoshi-automation
feat: add backup support (#100)
abd2ed6 
ed3874a
commit ed3874a
Author: Knut Olav Løite <koloite@gmail.com>
Date:   Thu Mar 19 08:43:21 2020 +0100

    feat: add backup support (#100)

google-cloud-spanner/clirr-ignored-differences.xml
google-cloud-spanner/pom.xml
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Backup.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupId.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClientImpl.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Instance.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/RestoreInfo.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java
google-cloud-spanner/src/main/java/com/google/cloud/spanner/testing/RemoteSpannerHelper.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupIdTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseAdminClientImplTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseAdminClientTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/GceTestEnvConfig.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/InstanceTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/MockDatabaseAdminServiceImpl.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/MockDatabaseAdminServiceImplTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/MockOperationsServiceImpl.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/ParallelIntegrationTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBackupTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBatchDmlTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBatchReadTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITClosedSessionTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITCommitTimestampTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDMLTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITLargeReadTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryOptionsTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITReadOnlyTxnTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITReadTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITSpannerOptionsTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITTransactionManagerTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITTransactionTest.java
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITWriteTest.java
yoshi-automation added a commit that referenced this issue Mar 25, 2020
@yoshi-automation
chore: release 1.52.0 (#110)
b4459d4 
1d3c4ac
commit 1d3c4ac
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Fri Mar 20 04:10:05 2020 +0000

    chore: release 1.52.0 (#110)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [1.52.0](https://www.github.com/googleapis/java-spanner/compare/v1.51.0...v1.52.0) (2020-03-20)

    ### Features

    * add backup support ([#100](https://www.github.com/googleapis/java-spanner/issues/100)) ([ed3874a](https://www.github.com/googleapis/java-spanner/commit/ed3874afcf55fe7381354e03dab3a3b97d7eb520))
    * add Backups protos and APIs ([#97](https://www.github.com/googleapis/java-spanner/issues/97)) ([5643c22](https://www.github.com/googleapis/java-spanner/commit/5643c22a4531dac75b9fac5b128eb714a27920a0))

    ### Bug Fixes

    * add client id to metrics to avoid collisions ([#117](https://www.github.com/googleapis/java-spanner/issues/117)) ([338e136](https://www.github.com/googleapis/java-spanner/commit/338e136508edc6745f9371e8a5d66638021bc8d7)), closes [#106](https://www.github.com/googleapis/java-spanner/issues/106)
    * ignore added interface methods for generated code ([#101](https://www.github.com/googleapis/java-spanner/issues/101)) ([402cfa1](https://www.github.com/googleapis/java-spanner/commit/402cfa1e1e2994f7bb1b783cf823021b54fb175e)), closes [#99](https://www.github.com/googleapis/java-spanner/issues/99)
    * use grpc 1.27.2 to prevent version conflicts ([#105](https://www.github.com/googleapis/java-spanner/issues/105)) ([37b7c88](https://www.github.com/googleapis/java-spanner/commit/37b7c8859e5f35d85bd14ef72662614fd185c020))

    ### Dependencies

    * update core dependencies ([#94](https://www.github.com/googleapis/java-spanner/issues/94)) ([f3ca4c9](https://www.github.com/googleapis/java-spanner/commit/f3ca4c99c3d54f64c5eda11e4a4c076140fdbc6a))
    * update opencensus.version to v0.26.0 ([#116](https://www.github.com/googleapis/java-spanner/issues/116)) ([1b8db0b](https://www.github.com/googleapis/java-spanner/commit/1b8db0b407429e02bb1e4c9af839afeed21dac5d))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).

CHANGELOG.md
README.md
google-cloud-spanner-bom/pom.xml
google-cloud-spanner/pom.xml
grpc-google-cloud-spanner-admin-database-v1/pom.xml
grpc-google-cloud-spanner-admin-instance-v1/pom.xml
grpc-google-cloud-spanner-v1/pom.xml
pom.xml
proto-google-cloud-spanner-admin-database-v1/pom.xml
proto-google-cloud-spanner-admin-instance-v1/pom.xml
proto-google-cloud-spanner-v1/pom.xml
versions.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli

@skuruppu skuruppu

Assignees
No one assigned
Labels
api: spanner cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@olavloite @hengfengli @skuruppu @googlebot @yoshi-kokoro