Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudshell editor link and runtime directory #1012

Merged
merged 1 commit into from Mar 24, 2021
Merged

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Mar 23, 2021

This will get the correct repo to clone, and instruct the user to switch directories to run commands, but I am not sure the fix is sufficient.

The samples (SpannerSample.java, QuickstartSample.java, BatchSample.java) use the default project, which seems to be unset when cloud shell opens. Perhaps they should be modified to take project ID as a runtime argument, too?

Fixes #1010

@elefeint elefeint requested review from as code owners Mar 23, 2021
@product-auto-label product-auto-label bot added the api: spanner label Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@elefeint elefeint requested a review from thiagotnunes Mar 23, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 23, 2021

Codecov Report

Merging #1012 (66d8261) into master (95cf759) will increase coverage by 0.00%.
The diff coverage is n/a.

Current head 66d8261 differs from pull request most recent head 018ebca. Consider uploading reports for the commit 018ebca to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1012   +/-   ##
=========================================
  Coverage     85.11%   85.12%           
- Complexity     2619     2621    +2     
=========================================
  Files           154      154           
  Lines         14324    14324           
  Branches       1334     1334           
=========================================
+ Hits          12192    12193    +1     
+ Misses         1569     1567    -2     
- Partials        563      564    +1     
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/spanner/connection/SpannerPool.java 87.36% <0.00%> (-0.53%) 33.00% <0.00%> (ø%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 18.00% <0.00%> (+1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.12% <0.00%> (+0.19%) 73.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cf759...018ebca. Read the comment docs.

Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Thanks for fixing this!

@thiagotnunes thiagotnunes merged commit 865bf01 into master Mar 24, 2021
18 checks passed
@thiagotnunes thiagotnunes deleted the fix-cloudshell branch Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants