Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plain text when testing emulator connection #1020

Merged
merged 2 commits into from Mar 30, 2021

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Mar 30, 2021

Uses plain text, instead of ssl when testing for local connections. This fixes connection checks when using the MockSpannerServiceImpl and it works with the emulator as well.

Without this fix we would get a transport error when testing the getConnection when using the MockSpannerServiceImpl, since the client would expect TLS, while the server would be serving plainText.

Uses plain text, instead of ssl when testing for local connections.
@thiagotnunes thiagotnunes requested a review from as a code owner Mar 30, 2021
@product-auto-label product-auto-label bot added the api: spanner label Mar 30, 2021
@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@thiagotnunes thiagotnunes requested a review from olavloite Mar 30, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 30, 2021

Codecov Report

Merging #1020 (f43896f) into master (25890de) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1020      +/-   ##
============================================
- Coverage     85.12%   85.10%   -0.02%     
+ Complexity     2627     2623       -4     
============================================
  Files           155      155              
  Lines         14369    14374       +5     
  Branches       1340     1340              
============================================
+ Hits          12231    12233       +2     
- Misses         1571     1573       +2     
- Partials        567      568       +1     
Impacted Files Coverage Δ Complexity Δ
...oud/spanner/connection/LocalConnectionChecker.java 82.05% <100.00%> (+8.52%) 6.00 <1.00> (+1.00)
.../google/cloud/spanner/AbstractLazyInitializer.java 92.85% <0.00%> (-7.15%) 4.00% <0.00%> (-1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 88.93% <0.00%> (-0.39%) 71.00% <0.00%> (-2.00%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25890de...f43896f. Read the comment docs.

@thiagotnunes thiagotnunes added the kokoro:force-run label Mar 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 30, 2021
Copy link
Contributor

@olavloite olavloite left a comment

Thanks for noticing that one!

@thiagotnunes thiagotnunes merged commit 1e6e23f into master Mar 30, 2021
17 of 18 checks passed
@thiagotnunes thiagotnunes deleted the fix-local-connection-checker-plain-text branch Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants