Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add keepalives to GRPC channel #11

Merged
merged 2 commits into from Jan 14, 2020
Merged

fix: add keepalives to GRPC channel #11

merged 2 commits into from Jan 14, 2020

Conversation

allenpradeep
Copy link
Contributor

@allenpradeep allenpradeep commented Jan 6, 2020

This patch adds keepalives to the GRPC channel every 2 minutes. By default, there are no keepalives to the GRPC channel. While running dataflow import jobs, issues have been observed with the spanner commit calls that run more than 10 minutes. Adding keepalives to the GRPC channel solves these issues.

@googlebot googlebot added the cla: yes label Jan 6, 2020
mbril
mbril approved these changes Jan 6, 2020
allenpradeep added 2 commits Jan 7, 2020
chore: update common templates (#12)
This patch adds keepalives to the GRPC channel every 2 minutes. By
default, there are no keepalives to the GRPC channel. While running
dataflow import jobs, issues have been observed with the spanner
commit calls that run more than 10 minutes. Adding keepalives to
the GRPC channel solves these issues.
@allenpradeep allenpradeep changed the title Add keepalives to GRPC channel fix: add keepalives to GRPC channel Jan 7, 2020
@allenpradeep
Copy link
Contributor Author

@allenpradeep allenpradeep commented Jan 7, 2020

@skuruppu - Can you please take a look at this.

@skuruppu skuruppu requested a review from olavloite Jan 9, 2020
Copy link
Contributor

@olavloite olavloite left a comment

LGTM.

@allenpradeep
Copy link
Contributor Author

@allenpradeep allenpradeep commented Jan 14, 2020

Hi @skuruppu,
I dont have write access to the repository. Can someone with write access merge this pull request?

@olavloite olavloite merged commit 428a4a6 into googleapis:master Jan 14, 2020
11 checks passed
@allenpradeep
Copy link
Contributor Author

@allenpradeep allenpradeep commented Jan 14, 2020

Thanks @olavloite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants