Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support encoded credentials in connection URL #1223

Merged
merged 1 commit into from May 31, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented May 27, 2021

This enables a user to specify a base64 encoded JSON string that contains the credentials that should be used for the connection. This removes the requirement to write the JSON string to a file before it can be used for a connection.

This property is the same as the spring.cloud.gcp.spanner.credentials.encoded-key property that is supported by spring-data-cloud-spanner.

Fixes googleapis/java-spanner-jdbc#486

This enables a user to specify a base64 encoded JSON string that contains the credentials
that should be used for the connection. This removes the requirement to write the JSON
string to a file before it can be used for a connection.

Fixes googleapis/java-spanner-jdbc#486
@olavloite olavloite requested a review from thiagotnunes May 27, 2021
@olavloite olavloite requested a review from as a code owner May 27, 2021
@product-auto-label product-auto-label bot added the api: spanner label May 27, 2021
@google-cla google-cla bot added the cla: yes label May 27, 2021
@thiagotnunes thiagotnunes merged commit 43d5d7e into master May 31, 2021
15 checks passed
@thiagotnunes thiagotnunes deleted the support-encoded-credentials-in-connection-url branch May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants