Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorten the test instance name #1284

Merged
merged 1 commit into from Jul 7, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jul 6, 2021

Shortens the display name of the test instance that is created for each sample test run.

(I've been able to verify that the test instance can now be created, but the test uses a fixed encryption key that is not available in my test project, so I've not been able to run the entire test. These tests are also only executed as part of the nightly build, so we'll only see the actual result tomorrow.)

Fixes #1277

@olavloite olavloite requested a review from thiagotnunes Jul 6, 2021
@olavloite olavloite requested a review from as a code owner Jul 6, 2021
@google-cla google-cla bot added the cla: yes label Jul 6, 2021
@product-auto-label product-auto-label bot added the api: spanner label Jul 6, 2021
@thiagotnunes thiagotnunes merged commit 07c3eae into master Jul 7, 2021
17 checks passed
@thiagotnunes thiagotnunes deleted the issue-1277-shorten-instance-name branch Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants