Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop databases after sample tests #1401

Merged
merged 1 commit into from Sep 1, 2021
Merged

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Aug 31, 2021

There was a bug on dropping databases / deleting backups after the sample tests where we were trying to delete in the regional instance first and if an exception was thrown, we would try to delete on the second instance. This did not work, because the delete / drop operations do not fail if the database / backup are not found in the instance, the call simply returns.

In this PR we have applied both deletes one after the other to fix the issue, instead of relying on the exceptions.

There was a bug on dropping databases / deleting backups after the
sample tests where we were trying to delete in the regional instance
first and if an exception was thrown, we would try to delete on the
second instance. This did not work, because the delete / drop operations
do not fail if the database / backup are not found in the instance, the
call simply returns.

In this PR we have applied both deletes one after the other to fix the
issue, instead of relying on the exceptions.
@thiagotnunes thiagotnunes requested a review from as a code owner Aug 31, 2021
@product-auto-label product-auto-label bot added api: spanner samples labels Aug 31, 2021
@google-cla google-cla bot added the cla: yes label Aug 31, 2021
@thiagotnunes thiagotnunes requested a review from olavloite Sep 1, 2021
@thiagotnunes thiagotnunes added the kokoro:force-run label Sep 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 1, 2021
@thiagotnunes thiagotnunes merged commit c9f5048 into master Sep 1, 2021
18 checks passed
@thiagotnunes thiagotnunes deleted the fix-samples-drop-databases branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants