Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sessions were not always removed from checkedOutSessions #1438

Merged
merged 2 commits into from Sep 23, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Sep 22, 2021

Sessions were added to a set of checked out sessions when one was checked out from
the session pool. When the session was released back to the pool, the session would
normally be removed from the set of checked out sessions. The latter would not always
happen if the application that checked out the session did not use the session for
any reads or writes.

Sessions were added to a set of checked out sessions when one was checked out from
the session pool. When the session was released back to the pool, the session would
normally be removed from the set of checked out sessions. The latter would not always
happen if the application that checked out the session did not use the session for
any reads or writes.
@olavloite olavloite requested a review from thiagotnunes Sep 22, 2021
@olavloite olavloite requested a review from as a code owner Sep 22, 2021
@google-cla google-cla bot added the cla: yes label Sep 22, 2021
@product-auto-label product-auto-label bot added the api: spanner label Sep 22, 2021
@olavloite olavloite merged commit 49360b1 into master Sep 23, 2021
18 checks passed
@olavloite olavloite deleted the remove-from-checked-out-if-not-used branch Sep 23, 2021
KiranmayiB pushed a commit to KiranmayiB/java-spanner that referenced this issue Sep 24, 2021
…apis#1438)

Sessions were added to a set of checked out sessions when one was checked out from
the session pool. When the session was released back to the pool, the session would
normally be removed from the set of checked out sessions. The latter would not always
happen if the application that checked out the session did not use the session for
any reads or writes.

Co-authored-by: Thiago Nunes <thiagotnunes@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants