Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep track of any BeginTransaction option for a Read #1485

Merged
merged 1 commit into from Oct 6, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Oct 5, 2021

If a StreamingReadRequest that included a BeginTransaction option was retried as a result
of a transient error (UNAVAILABLE), the fact that the BeginTransaction option was included
would not be registered for the retried request. This could cause a transaction to fail if
the retried request returned an Aborted error, and that Aborted error was caught by the
application.

If a StreamingReadRequest that included a BeginTransaction option was retried as a result
of a transient error (UNAVAILABLE), the fact that the BeginTransaction option was included
would not be registered for the retried request. This could cause a transaction to fail if
the retried request returned an Aborted error, and that Aborted error was caught by the
application.
@olavloite olavloite requested a review from thiagotnunes Oct 5, 2021
@olavloite olavloite requested a review from as a code owner Oct 5, 2021
@product-auto-label product-auto-label bot added the api: spanner label Oct 5, 2021
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@thiagotnunes thiagotnunes merged commit 757d6ec into main Oct 6, 2021
18 checks passed
@thiagotnunes thiagotnunes deleted the remember-with-transaction-for-read branch Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants