Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up test instance if creation failed #162

merged 1 commit into from Apr 22, 2020

fix: clean up test instance if creation failed #162

merged 1 commit into from Apr 22, 2020


Copy link

@olavloite olavloite commented Apr 21, 2020

The integration test environment tries to cancel the CreateInstance RPC, and otherwise tries to delete the instance, if the creation fails. This also adds the methods getOperation and cancelOperation to InstanceAdminClient. These had already been added to DatabaseAdminClient, but not to InstanceAdminClient.

Fixes #144

@googlebot googlebot added the cla: yes label Apr 21, 2020
@olavloite olavloite added the kokoro:force-run label Apr 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 21, 2020
@olavloite olavloite requested review from skuruppu and hengfengli Apr 21, 2020
Copy link

@hengfengli hengfengli left a comment

LGTM. Thanks for fixing this.

@olavloite olavloite merged commit ff571e1 into master Apr 22, 2020
12 of 13 checks passed
@olavloite olavloite deleted the issue-144 branch Apr 22, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 22, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [1.53.0]( (2020-04-22)

### Features

* optimize maintainer to let sessions be GC'ed instead of deleted ([#135]( ([d65747c](

### Bug Fixes

* assign unique id's per test case ([#129]( ([a553b6d](
* check for not null input for Id classes ([#159]( ([ecf5826](, closes [#145](
* clean up test instance if creation failed ([#162]( ([ff571e1](
* fix flaky test and remove warnings ([#153]( ([d534e35](, closes [#146](
* increase test timeout and remove warnings ([#160]( ([63a6bd8](, closes [#158](
* retry non-idempotent long-running RPCs ([#141]( ([4669c02](
* retry restore if blocked by pending restore ([#119]( ([220653d](, closes [#118](
* StatementParser did not accept multiple query hints ([#170]( ([ef41a6e](, closes [#163](
* wait for initialization to finish before test ([#161]( ([fe434ff](, closes [#146](

### Performance Improvements

* increase sessions in the pool in batches ([#134]( ([9e5a1cd](
* prepare sessions with r/w tx in-process ([#152]( ([2db27ce](, closes [#151](

### Dependencies

* update core dependencies ([#109]( ([5753f1f](
* update core dependencies ([#132]( ([77c1558](
* update dependency to v1.9.0 ([#127]( ([b2c744f](
* update dependency to v29 ([#147]( ([3fe3ae0](
* update dependency io.grpc:grpc-bom to v1.29.0 ([#164]( ([2d2ce5c](
* update dependency org.threeten:threetenbp to v1.4.3 ([#120]( ([49d1abc](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

5 participants