From 3ab67058e40e826bbbea855b69985a00ec694cce Mon Sep 17 00:00:00 2001 From: Kiranmayi Bhamidimarri Date: Thu, 3 Mar 2022 11:13:39 +0530 Subject: [PATCH 1/2] fix: Correct recording values in opencensus measureMap in HeaderInterceptor --- .../com/google/cloud/spanner/spi/v1/HeaderInterceptor.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java index 3f4372db84..474b23e610 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java @@ -95,8 +95,9 @@ private void processHeader(Metadata metadata, TagContext tagContext) { if (matcher.find()) { try { long latency = Long.parseLong(matcher.group("dur")); - measureMap.put(SPANNER_GFE_LATENCY, latency).record(tagContext); - measureMap.put(SPANNER_GFE_HEADER_MISSING_COUNT, 0L).record(tagContext); + measureMap.put(SPANNER_GFE_LATENCY, latency); + measureMap.put(SPANNER_GFE_HEADER_MISSING_COUNT, 0L); + measureMap.record(tagContext); } catch (NumberFormatException e) { LOGGER.log(LEVEL, "Invalid server-timing object in header", matcher.group("dur")); } From 4153d88984753bf314606883379b49edf67f107c Mon Sep 17 00:00:00 2001 From: Kiranmayi Bhamidimarri Date: Thu, 3 Mar 2022 11:15:44 +0530 Subject: [PATCH 2/2] fix: Correct recording values in opencensus measureMap in HeaderInterceptor --- .../java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java index 474b23e610..d4725b2542 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java @@ -97,7 +97,7 @@ private void processHeader(Metadata metadata, TagContext tagContext) { long latency = Long.parseLong(matcher.group("dur")); measureMap.put(SPANNER_GFE_LATENCY, latency); measureMap.put(SPANNER_GFE_HEADER_MISSING_COUNT, 0L); - measureMap.record(tagContext); + measureMap.record(tagContext); } catch (NumberFormatException e) { LOGGER.log(LEVEL, "Invalid server-timing object in header", matcher.group("dur")); }