Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create filter in correct order #180

Merged
merged 3 commits into from Apr 28, 2020
Merged

fix: create filter in correct order #180

merged 3 commits into from Apr 28, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Apr 24, 2020

Fixes #179

@googlebot googlebot added the cla: yes label Apr 24, 2020
@olavloite olavloite added the kokoro:force-run label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 24, 2020
@olavloite olavloite added the kokoro:force-run label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 24, 2020
@olavloite olavloite added the kokoro:force-run label Apr 25, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 25, 2020
@olavloite olavloite added the kokoro:force-run label Apr 25, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 25, 2020
@olavloite olavloite added the kokoro:force-run label Apr 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 26, 2020
@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Apr 26, 2020

@googlebot I consent.

@olavloite olavloite requested review from skuruppu and hengfengli Apr 26, 2020
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM.

@hengfengli
Copy link
Contributor

@hengfengli hengfengli commented Apr 27, 2020

We probably should file the order of filter issue to the backend team.

@olavloite olavloite merged commit d80428a into master Apr 28, 2020
13 checks passed
@olavloite olavloite deleted the issue-179 branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants