Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove error message checking #183

Merged
merged 1 commit into from Apr 29, 2020
Merged

fix: remove error message checking #183

merged 1 commit into from Apr 29, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Apr 25, 2020

  • Removes specific error message checking, as the backend may change these without prior notice.
  • Removes warnings regarding deprected ExpectedException class.
  • Refactored to reuse the same table for most tests to reduce execution time.

Fixes #175

@googlebot googlebot added the cla: yes label Apr 25, 2020
@olavloite olavloite added the kokoro:force-run label Apr 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 26, 2020
@olavloite olavloite requested review from skuruppu and hengfengli Apr 26, 2020
@olavloite olavloite added the kokoro:force-run label Apr 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 27, 2020
@olavloite olavloite added the kokoro:force-run label Apr 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 27, 2020
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
Copy link
Contributor

@skuruppu skuruppu left a comment

Perfect, thank you for the change.

@olavloite olavloite merged commit b477322 into master Apr 29, 2020
13 checks passed
@olavloite olavloite deleted the issue-175 branch Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants