Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting compression option #192

Merged
merged 6 commits into from Jun 30, 2020
Merged

feat: support setting compression option #192

merged 6 commits into from Jun 30, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented May 6, 2020

Adds support for setting the compressor to use for gRPC calls.

@olavloite olavloite requested a review from skuruppu May 6, 2020
@googlebot googlebot added the cla: yes label May 6, 2020
client
.singleUse()
.executeQuery(Statement.of("SELECT 1 AS COL1 UNION ALL SELECT 2 AS COL2"))) {
assertThat(rs.next()).isTrue();
Copy link

@rven1 rven1 May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to test an end to end compression and verify that the compressor is actually used.

Copy link
Contributor

@skuruppu skuruppu May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes absolutely. Once the support is in the staging environment, we can run this IT against it to test the change. @olavloite I'll give you a heads up when the feature is available in staging.

@skuruppu skuruppu added the do not merge label May 15, 2020
@skuruppu skuruppu removed the do not merge label Jun 29, 2020
@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jun 29, 2020

@olavloite we can merge this change now. If you can resolve the conflict and merge, that would be great.

@skuruppu skuruppu closed this Jun 29, 2020
@skuruppu skuruppu reopened this Jun 29, 2020
@olavloite olavloite merged commit 965e95e into master Jun 30, 2020
22 checks passed
@olavloite olavloite deleted the compression branch Jun 30, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants