Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for NUMERIC data type #193

merged 7 commits into from Jul 15, 2020


Copy link

@olavloite olavloite commented May 6, 2020

No description provided.

@olavloite olavloite added do not merge api: spanner labels May 6, 2020
@olavloite olavloite requested a review from skuruppu May 6, 2020
@googlebot googlebot added the cla: yes label May 6, 2020
@skuruppu skuruppu requested a review from thiagotnunes Jul 7, 2020
Copy link

@thiagotnunes thiagotnunes left a comment

From a first time reviewing, it looks good to me, I think I still lack a bit of understanding on how all the pieces come together.

@@ -352,6 +356,21 @@ public void writeDateNull() {

Copy link

@skuruppu skuruppu Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olavloite thanks for adding the integration tests. But I do have one small request. Would you be able to move it to a separate PR?

The reason being that we will merge this PR in before support for the feature is available in prod, which unfortunately mean that the tests will fail at that point.

Copy link
Contributor Author

@olavloite olavloite Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP, I'll move them to a separate PR.

@olavloite olavloite changed the base branch from java-code-regen to master Jul 15, 2020
@skuruppu skuruppu removed the do not merge label Jul 15, 2020
@skuruppu skuruppu merged commit b38a91d into googleapis:master Jul 15, 2020
23 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [1.59.0]( (2020-07-16)

### Features

* add support for NUMERIC data type ([#193]( ([b38a91d](
* spanner NUMERIC type ([#349]( ([78c3192](

### Bug Fixes

* check if emulator is running if env var is set ([#340]( ([597f501](
* fix potential unnecessary transaction retry ([#337]( ([1a4f4fd](, closes [#327](
* respect PDML timeout when using streaming RPC ([#338]( ([d67f108](
* runs sample tests in java 8 and java 11 ([#345]( ([b547e31](
* set gRPC keep-alive to 120 seconds ([#339]( ([26be103](

### Dependencies

* update dependency to v0.8.3 ([#334]( ([45acd89](
* update shared config to 0.9.2 ([#328]( ([75df62c](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: spanner cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants