Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reuse clientId for invalidated databases #206

merged 2 commits into from May 15, 2020


Copy link

@olavloite olavloite commented May 13, 2020

A new client id would be generated each time a DatabaseClient was requested for a non-existing database. This change ensures that the same client id will be re-used for a DatabaseClient that has been created by a Spanner instance, also after it has been invalidated.

Fixes #202

@googlebot googlebot added the cla: yes label May 13, 2020
@olavloite olavloite added the kokoro:force-run label May 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 13, 2020
@olavloite olavloite force-pushed the reuse-client-id-for-invalidated-dbs branch from a1499c6 to c9ba71a Compare May 14, 2020
@olavloite olavloite requested a review from skuruppu May 14, 2020
@skuruppu skuruppu merged commit 7b4490d into master May 15, 2020
13 checks passed
@skuruppu skuruppu deleted the reuse-client-id-for-invalidated-dbs branch May 15, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue May 19, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [1.55.0]( (2020-05-19)

### Features

* mark when a Spanner client is closed ([#198]( ([50cb174](

### Bug Fixes

* make it possible to override backups methods ([#195]( ([2d19c25](
* Partitioned DML timeout was not always respected ([#203]( ([13cb37e](, closes [#199](
* partitionedDml stub was not closed ([#213]( ([a2d9a33](
* reuse clientId for invalidated databases ([#206]( ([7b4490d](
* use nanos to prevent truncation errors ([#204]( ([a608460](, closes [#200](

### Dependencies

* update dependency to v0.3.1 ([#190]( ([ad41a0d](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

4 participants