Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the need for any env var in all tests #235

Merged
merged 1 commit into from May 21, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented May 21, 2020

Some tests relied on an environment variable having been set for a default project id credentials file. This change removes this dependency by setting an explicit project id and credentials instance.

Fixes the build error in #218

Towards #219

Some tests relied on an environment variable having been set for a default
project id credentials file. This change removes this dependency by setting
an explicit project id and credentials instance.
@googlebot googlebot added the cla: yes label May 21, 2020
@skuruppu skuruppu merged commit 374fb40 into master May 21, 2020
12 checks passed
@skuruppu skuruppu deleted the remove-need-for-env-vars branch May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants