Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backend now supports optimizer version for DML #252

Merged
merged 8 commits into from Jun 10, 2020
Merged

fix: backend now supports optimizer version for DML #252

merged 8 commits into from Jun 10, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jun 9, 2020

Fixes #249 ☕️

@googlebot googlebot added the cla: yes label Jun 9, 2020
@olavloite olavloite requested a review from skuruppu Jun 9, 2020
@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Jun 9, 2020

@skuruppu
The build error for the code format seems to be caused by a non-related problem. The failing integration test that is fixed by this PR is however breaking all other PRs, so I think we should consider merging this PR even without a successful Code Format check.

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jun 10, 2020

Oooh I have no idea what this error means:

java.lang.UnsupportedClassVersionError: com/google/googlejavaformat/java/FormatterException has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Unfortunately, I don't have the permissions to force-merge PRs.

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 10, 2020

This will be fixed by google-cloud-shared-config 0.7.0 which is releasing now.

@olavloite olavloite added the automerge label Jun 10, 2020
@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Jun 10, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Jun 10, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@olavloite olavloite removed the automerge label Jun 10, 2020
@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 10, 2020

@stephaniewang526 are these extra auto value changes expected from shared-config 0.7.0?

@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Jun 10, 2020

@chingor13 Any idea why it seems like Java11 needs to be used for the Code Format build for it to succeed? Or am I missing something there?

@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Jun 10, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 10, 2020

So the lint error after updating the shared config was because we also need to update .kokoro/build.sh from https://github.com/googleapis/java-spanner/pull/251/files#diff-ce0d2ea7b6085e6c4bd286d0a15a3971

The auto value changes don't seem to be necessary unless you use auto value

@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Jun 10, 2020

So the lint error after updating the shared config was because we also need to update .kokoro/build.sh from https://github.com/googleapis/java-spanner/pull/251/files#diff-ce0d2ea7b6085e6c4bd286d0a15a3971

The auto value changes don't seem to be necessary unless you use auto value

Great, thanks for looking into that. I'll include that change here and try to walk back as many of the other changes as possible while still keeping the build green. Once that's done, I'll try to fix the other PR's that are failing because of the integration test that is fixed by this PR.

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Jun 10, 2020

@olavloite is the autovalue change in shared-config affecting you somehow?

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jun 10, 2020

I'm going to merge this in while the build is green. Then I'll get the presubmits running on the other PRs that are blocked.

@skuruppu skuruppu merged commit 24b986b into master Jun 10, 2020
13 checks passed
@skuruppu skuruppu deleted the issue-249 branch Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants