Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: include test-jar in bom #253

Merged
merged 1 commit into from Jun 11, 2020
Merged

deps: include test-jar in bom #253

merged 1 commit into from Jun 11, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jun 9, 2020

Including the google-cloud-spanner test-jar in the bom will allow other libraries to use the test jar without having to specify a version. This again should prevent the kind of failures that we are currently seeing in googleapis/java-spanner-jdbc#142

(The jdbc driver currently defines a specific version for the test-jar in the pom here.)

@googlebot googlebot added the cla: yes label Jun 9, 2020
@olavloite olavloite requested review from chingor13 and skuruppu Jun 9, 2020
@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Jun 9, 2020

The integration test failures are not related to this change, and will be fixed by #252. The code format failure is as far as I can tell also not related to this change.

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jun 10, 2020

Unfortunately, I don't have the permissions to force-merge if required checks fail :(

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 10, 2020

The lint problem should be fixed by google-cloud-shared-config 0.7.0 which is releasing now - google-java-format shipped a version incompatible with Java 8

@skuruppu skuruppu added the kokoro:force-run label Jun 11, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 11, 2020
@skuruppu skuruppu merged commit 4e86a37 into master Jun 11, 2020
13 checks passed
@skuruppu skuruppu deleted the include-test-jar-in-bom branch Jun 11, 2020
olavloite added a commit that referenced this issue Nov 4, 2020
Some enums were defined as package-private, but these were used in the
public API of the Connection API. That made the specific methods in the
Connection API unusable from outside the Spanner client library.

Towards #253
olavloite added a commit that referenced this issue Nov 5, 2020
Some enums were defined as package-private, but these were used in the
public API of the Connection API. That made the specific methods in the
Connection API unusable from outside the Spanner client library.

Towards #253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants