Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for CallCredentials #26

Merged
merged 2 commits into from Jan 14, 2020
Merged

feat: add support for CallCredentials #26

merged 2 commits into from Jan 14, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jan 10, 2020

Adds support for using CallCredentials that could vary per call instead of only static credentials passed in at startup.

Fixes #18

Adds support for using CallCredentials that could vary per call
instead of only static credentials passed in at startup.

Fixes #18
@googlebot googlebot added the cla: yes label Jan 10, 2020
@olavloite olavloite requested review from skuruppu and hengfengli Jan 13, 2020
@olavloite olavloite added the type: feature request label Jan 13, 2020
@Capstan
Copy link

@Capstan Capstan commented Jan 13, 2020

LGTM. I believe this would work for our purposes.

Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM, 👍

@olavloite olavloite merged commit 1112357 into master Jan 14, 2020
11 checks passed
@olavloite olavloite deleted the call-credentials branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants