From 8f7972f01da52ba7dfcbaac44706275169a3403f Mon Sep 17 00:00:00 2001 From: kurisumakise2011 Date: Wed, 24 Jun 2020 16:50:54 +0300 Subject: [PATCH] feature: Increase a length of debug string Increase length of debug string to 36, due to UUID length. According to https://tools.ietf.org/html/rfc4122#section-3 It provides the formal definition of UUID string representations. It's 36 characters (32 hex digits + 4 dashes) It should be more convenient to debugging statements --- .../src/main/java/com/google/cloud/spanner/Value.java | 2 +- .../src/test/java/com/google/cloud/spanner/ValueTest.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java index 63b9a3a1350..c32b5fde816 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java @@ -71,7 +71,7 @@ public abstract class Value implements Serializable { */ public static final Timestamp COMMIT_TIMESTAMP = Timestamp.ofTimeMicroseconds(0L); - private static final int MAX_DEBUG_STRING_LENGTH = 32; + private static final int MAX_DEBUG_STRING_LENGTH = 36; private static final String ELLIPSIS = "..."; private static final String NULL_STRING = "NULL"; private static final char LIST_SEPERATOR = ','; diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java index 22c8261db9b..dbc9c8ea618 100644 --- a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java +++ b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java @@ -212,11 +212,11 @@ public void stringNull() { @Test public void stringLong() { - String str = "aaaaaaaaaabbbbbbbbbbccccccccccdddddddddd"; + String str = "aaaaaaaaaabbbbbbbbbbccccccccccddddddddddeee"; Value v = Value.string(str); assertThat(v.getString()).isEqualTo(str); - assertThat(v.toString()).hasLength(32); - assertThat(v.toString()).startsWith(str.substring(0, 32 - 3)); + assertThat(v.toString()).hasLength(36); + assertThat(v.toString()).startsWith(str.substring(0, 36 - 3)); assertThat(v.toString()).endsWith("..."); }