Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies and update ExecutorProvider #302

Merged
merged 4 commits into from Jun 25, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jun 24, 2020

Replaces #284

@googlebot googlebot added the cla: yes label Jun 24, 2020
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Jun 24, 2020

seeing [ERROR] Failures: [ERROR] SpannerOptionsThreadTest.testCloseAllThreadsWhenClosingSpanner:103 expected: 16

@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Jun 24, 2020

seeing [ERROR] Failures: [ERROR] SpannerOptionsThreadTest.testCloseAllThreadsWhenClosingSpanner:103 expected: 16

Yeah, I noticed as well, and I'm looking into it. Locally the test succeeds. My initial guess is that it might be caused by the thread group of the thread that is running the test on the CI env is a different group than group of the gax threads.

@skuruppu skuruppu merged commit 5aef6c3 into master Jun 25, 2020
21 checks passed
@skuruppu skuruppu deleted the flatten-plugin branch Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants