Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default values for streaming retry #316

Merged
merged 1 commit into from Jul 6, 2020
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jul 1, 2020

Include default fallback values in case the retry settings are removed or set to values that are invalid (i.e. 0).

@olavloite olavloite requested a review from skuruppu Jul 1, 2020
@googlebot googlebot added the cla: yes label Jul 1, 2020
@skuruppu skuruppu added the kokoro:force-run label Jul 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 1, 2020
@olavloite olavloite added the kokoro:force-run label Jul 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 6, 2020
@olavloite olavloite added the kokoro:force-run label Jul 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 6, 2020
@olavloite olavloite merged commit 543373b into master Jul 6, 2020
23 checks passed
@olavloite olavloite deleted the streaming-retry branch Jul 6, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants