Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop sending RPCs to deleted database #34

Merged
merged 6 commits into from Jan 22, 2020
Merged

fix: stop sending RPCs to deleted database #34

merged 6 commits into from Jan 22, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jan 14, 2020

DatabaseClients should not continue to try to send RPCs to a database that has been deleted. Instead, the session pool will keep track of whether a DatabaseNotFound error has been returned for a database, and if so, will invalidate itself. All subsequent calls for this database will return a DatabaseNotFoundException without calling a RPC.

If a database is re-created, the user must create a new DatabaseClient with a new session pool in order to resume usage of the database.

Fixes #16

@googlebot googlebot added the cla: yes label Jan 14, 2020
@olavloite olavloite added the kokoro:force-run label Jan 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 14, 2020
@olavloite olavloite requested review from skuruppu and hengfengli Jan 15, 2020
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM.

@olavloite olavloite added the kokoro:force-run label Jan 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 20, 2020
olavloite added 6 commits Jan 22, 2020
DatabaseClients should not continue to try to send RPCs to a database that has
been deleted. Instead, the session pool will keep track of whether a database
not found error has been returned for a database, and if so, will invalidate
itself. All subsequent calls for this database will return a DatabaseNotFoundException
without calling a RPC.

If a database is re-created, the user must create a new DatabaseClient with a new
session pool in order to resume usage of the database.

Fixes #16
@olavloite olavloite merged commit 11e4a90 into master Jan 22, 2020
11 checks passed
@olavloite olavloite deleted the database-deleted branch Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants