fix: stop sending RPCs to deleted database #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPool.java
Show resolved
Hide resolved
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerExceptionFactory.java
Show resolved
Hide resolved
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java
Show resolved
Hide resolved
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseTest.java
Show resolved
Hide resolved
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
skuruppu
approved these changes
Jan 21, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseNotFoundException.java
Outdated
Show resolved
Hide resolved
DatabaseClients should not continue to try to send RPCs to a database that has been deleted. Instead, the session pool will keep track of whether a database not found error has been returned for a database, and if so, will invalidate itself. All subsequent calls for this database will return a DatabaseNotFoundException without calling a RPC. If a database is re-created, the user must create a new DatabaseClient with a new session pool in order to resume usage of the database. Fixes #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
DatabaseClients should not continue to try to send RPCs to a database that has been deleted. Instead, the session pool will keep track of whether a DatabaseNotFound error has been returned for a database, and if so, will invalidate itself. All subsequent calls for this database will return a DatabaseNotFoundException without calling a RPC.
If a database is re-created, the user must create a new DatabaseClient with a new session pool in order to resume usage of the database.
Fixes #16