Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if emulator is running if env var is set #340

merged 2 commits into from Jul 14, 2020


Copy link

@olavloite olavloite commented Jul 10, 2020

Check whether the emulator is actually running if the environment variable has been set to localhost.

Fixes #326

@googlebot googlebot added the cla: yes label Jul 10, 2020
@olavloite olavloite requested review from skuruppu and thiagotnunes Jul 10, 2020
Copy link

@thiagotnunes thiagotnunes commented Jul 11, 2020

Thanks for the fix @olavloite, will run some tests on Monday and review the PR!

Copy link

@thiagotnunes thiagotnunes left a comment

Tested locally, LGTM

@olavloite olavloite merged commit 597f501 into master Jul 14, 2020
23 checks passed
@olavloite olavloite deleted the check-emulator-is-running branch Jul 14, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [1.59.0]( (2020-07-16)

### Features

* add support for NUMERIC data type ([#193]( ([b38a91d](
* spanner NUMERIC type ([#349]( ([78c3192](

### Bug Fixes

* check if emulator is running if env var is set ([#340]( ([597f501](
* fix potential unnecessary transaction retry ([#337]( ([1a4f4fd](, closes [#327](
* respect PDML timeout when using streaming RPC ([#338]( ([d67f108](
* runs sample tests in java 8 and java 11 ([#345]( ([b547e31](
* set gRPC keep-alive to 120 seconds ([#339]( ([26be103](

### Dependencies

* update dependency to v0.8.3 ([#334]( ([45acd89](
* update shared config to 0.9.2 ([#328]( ([75df62c](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

4 participants