Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove potential infinite loop in administrative requests #398

Merged
merged 1 commit into from Aug 27, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Aug 26, 2020

The automatic retryer for non-idempotent administrative requests did not keep track of the nextPageToken correctly when querying the backend for running operations. This could cause an infinite loop if a resource (database/backup) with the same name had been created repeatedly on the same instance.

The automatic retryer for non-idempotent administrative requests did not keep
track of the nextPageToken correctly when querying the backend for running
operations. This could cause an infinite loop if a resource (database/backup)
with the same name had been created repeatedly on the same instance.
@google-cla google-cla bot added the cla: yes label Aug 26, 2020
@olavloite olavloite requested review from skuruppu and thiagotnunes Aug 26, 2020
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Nice catch!

@product-auto-label product-auto-label bot added the api: spanner label Aug 27, 2020
@olavloite olavloite merged commit 81d2c76 into master Aug 27, 2020
16 checks passed
@olavloite olavloite deleted the fix-potential-infinite-loop branch Aug 27, 2020
thiagotnunes pushed a commit to thiagotnunes/java-spanner that referenced this issue Jun 5, 2021
…eapis#398)

The automatic retryer for non-idempotent administrative requests did not keep
track of the nextPageToken correctly when querying the backend for running
operations. This could cause an infinite loop if a resource (database/backup)
with the same name had been created repeatedly on the same instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants