Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guava ImmutableList from API surface. #411

Merged
merged 1 commit into from Sep 10, 2020
Merged

Remove Guava ImmutableList from API surface. #411

merged 1 commit into from Sep 10, 2020

Conversation

nielm
Copy link
Contributor

@nielm nielm commented Sep 1, 2020 •
edited

Replace com.google.common.collect.ImmutableList
with java.util.List

Fixes #410 ☕️

@google-cla google-cla bot added the cla: yes label Sep 1, 2020
@nielm
Copy link
Contributor Author

@nielm nielm commented Sep 1, 2020

@olavloite as he wrote the code I am modifying.
I don't know if the benefits of changing this API surface outweigh the cost of breaking binary compatibility with older library versions...

@nielm nielm mentioned this pull request Sep 1, 2020
Closed
@nielm nielm force-pushed the noguava branch 6 times, most recently from 70319ac to ecb43c5 Compare Sep 1, 2020
@product-auto-label product-auto-label bot added the api: spanner label Sep 2, 2020
@nielm nielm changed the title Remove use of Guava types from API surface. Remove Guava ImmutableList from API surface. Sep 8, 2020
@nielm
Copy link
Contributor Author

@nielm nielm commented Sep 8, 2020

Updated to only replace ImmutableList -> List to keep JDK 1.7 compatibility.

@olavloite
Copy link
Contributor

@olavloite olavloite commented Sep 8, 2020

@nielm You need to add an entry to https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/clirr-ignored-differences.xml make the clirr plugin stop complaining. Otherwise this LGTM.

@nielm
fix: Remove Guava ImmutableList from API surface
d62f6c2 
Replace com.google.common.collect.ImmutableList
with java.util.List

BREAKING CHANGE
@nielm
Copy link
Contributor Author

@nielm nielm commented Sep 8, 2020

@nielm You need to add an entry to https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/clirr-ignored-differences.xml make the clirr plugin stop complaining. Otherwise this LGTM.

Thanks, Knut, Done!

@olavloite olavloite requested a review from thiagotnunes Sep 8, 2020
thiagotnunes
thiagotnunes approved these changes Sep 10, 2020
View changes
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

LGTM

@thiagotnunes thiagotnunes added the kokoro:force-run label Sep 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 10, 2020
@thiagotnunes thiagotnunes merged commit b35304e into googleapis:master Sep 10, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes

@olavloite olavloite

Assignees
No one assigned
Labels
api: spanner cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Guava classes in AsyncResultSet exposes it on API surface
4 participants
@nielm @olavloite @thiagotnunes @yoshi-kokoro