Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterate over async result set in sync #416

Merged
merged 1 commit into from Sep 9, 2020
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Sep 8, 2020

Iterating over an AsyncResultSet using a standard while (rs.next()) loop would fail after the last row was consumed.

Iterating over an AsyncResultSet using a standard while (rs.next()) loop
would fail after the last row was consumed.
@google-cla google-cla bot added the cla: yes label Sep 8, 2020
@olavloite olavloite requested review from skuruppu and thiagotnunes Sep 8, 2020
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

LGTM

@thiagotnunes thiagotnunes added the kokoro:force-run label Sep 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 8, 2020
@product-auto-label product-auto-label bot added the api: spanner label Sep 9, 2020
@olavloite olavloite merged commit 45d8419 into master Sep 9, 2020
16 checks passed
@olavloite olavloite deleted the iterate-async-res-in-sync branch Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants