Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve numeric range checks #424

Merged
merged 2 commits into from Sep 18, 2020
Merged

fix: improve numeric range checks #424

merged 2 commits into from Sep 18, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Sep 14, 2020

Adds additional checks on NUMERIC values before sending them to Cloud Spanner in order to return sensible error messages as soon as possible, and adds documentation on how to handle NUMERIC values with trailing zeros in the fractional part.

@google-cla google-cla bot added the cla: yes label Sep 14, 2020
@olavloite olavloite requested review from skuruppu and thiagotnunes Sep 14, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 14, 2020

Codecov Report

Merging #424 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #424      +/-   ##
============================================
+ Coverage     82.16%   82.18%   +0.01%     
- Complexity     2455     2458       +3     
============================================
  Files           136      136              
  Lines         13589    13599      +10     
  Branches       1307     1310       +3     
============================================
+ Hits          11166    11176      +10     
  Misses         1895     1895              
  Partials        528      528              
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/google/cloud/spanner/Value.java 87.81% <100.00%> (+0.28%) 63.00 <5.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b312091...abb579c. Read the comment docs.

@product-auto-label product-auto-label bot added the api: spanner label Sep 15, 2020
@olavloite olavloite merged commit 9f26785 into master Sep 18, 2020
18 checks passed
@olavloite olavloite deleted the numeric-range-checks branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants