fix: uses old version of gax-grpc method #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
============================================
- Coverage 82.16% 82.14% -0.03%
- Complexity 2455 2459 +4
============================================
Files 136 136
Lines 13589 13589
Branches 1307 1307
============================================
- Hits 11166 11163 -3
- Misses 1895 1897 +2
- Partials 528 529 +1
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Sep 15, 2020
skuruppu
reviewed
Sep 15, 2020
| // Before updating this method to setExecutor, please make sure to verify the version | ||
| // of gax-grpc used internally. At the moment we are using 1.47.1, which does not | ||
| // support the setExecutor variant. |
There was a problem hiding this comment.
This comment may not give enough context for folks outside of Google. So instead reword to something like:
"Before updating this method to setExecutor, please verify with a code owner on the lowest version of gax-grpc that needs to be supported. Currently v1.47.17, which doesn't support the setExecutor variant."
Internally, we are using version 1.47.1 of the gax-grpc library, which does not provide a method currently being used (setExecutor). In here we use a method that is available in 1.47.1 and achieves the same goal (setExecutorProvider).
thiagotnunes
force-pushed
the
use-old-version-of-gax-grpc-method
branch
from
94fd5bb
to
4ed38fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Internally, we are using version 1.47.1 of the gax-grpc library, which does not provide a method currently being used (setExecutor).
In here we use a method that is available in 1.47.1 and achieves the same goal (setExecutorProvider).