Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "perf: close sessions async" #43

Merged
merged 1 commit into from Jan 23, 2020
Merged

Conversation

skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jan 23, 2020

Reverts #24

The change continues to cause compatibility test failures.

@googlebot googlebot added the cla: yes label Jan 23, 2020
@skuruppu skuruppu requested a review from hengfengli Jan 23, 2020
@hengfengli hengfengli merged commit 809ed88 into master Jan 23, 2020
11 checks passed
@hengfengli hengfengli deleted the revert-24-close-sessions-async branch Jan 23, 2020
@release-please release-please bot mentioned this pull request Jan 23, 2020
skuruppu added a commit that referenced this issue Jan 24, 2020
olavloite pushed a commit that referenced this issue Jan 24, 2020
* Revert "Revert "perf: close sessions async (#24)" (#43)"

This reverts commit 809ed88.

* Ignore compatibility check failure in internal interfaces.

asyncClose() was added to com.google.cloud.spanner.Session and
asyncDeleteSession() was added to
com.google.cloud.spanner.spi.v1.SpannerRpc in #24 which resulted in
binary compatibility test failures. This config allows us to ignore the
failure.

* Annotate SpannerRpc and Session classes as @internalapi.

Users shouldn't be implementing these interfaces as they're internal to
the client library implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants