Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-adds method used in internal testing #438

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Sep 18, 2020

We had removed a method from GapicSpannerRpc that was used in the internal testing infrastructure. We are adding this back for the time being.

@google-cla google-cla bot added the cla: yes label Sep 18, 2020
@thiagotnunes thiagotnunes requested a review from skuruppu Sep 18, 2020
@thiagotnunes thiagotnunes force-pushed the re-add-method-in-gapic-spanner-rpc branch from d8362d1 to 2036d1c Compare Sep 18, 2020
We had removed a method from GapicSpannerRpc that was used in the
internal testing infrastructure. We are adding this back for the time
being.
@thiagotnunes thiagotnunes force-pushed the re-add-method-in-gapic-spanner-rpc branch from 2036d1c to ba5a961 Compare Sep 18, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 18, 2020

Codecov Report

Merging #438 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #438      +/-   ##
============================================
- Coverage     82.18%   82.16%   -0.02%     
+ Complexity     2463     2460       -3     
============================================
  Files           138      138              
  Lines         13605    13606       +1     
  Branches       1309     1309              
============================================
- Hits          11181    11180       -1     
- Misses         1896     1897       +1     
- Partials        528      529       +1     
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 81.92% <0.00%> (-0.12%) 81.00 <0.00> (ø)
.../google/cloud/spanner/AbstractLazyInitializer.java 92.85% <0.00%> (-7.15%) 4.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5d3a5...ba5a961. Read the comment docs.

@thiagotnunes thiagotnunes merged commit c36e41b into googleapis:master Sep 18, 2020
16 of 18 checks passed
@thiagotnunes thiagotnunes deleted the re-add-method-in-gapic-spanner-rpc branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants