Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: close sessions async revert revert #46

Merged
merged 3 commits into from Jan 24, 2020

Conversation

skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jan 24, 2020

We reverted #24 due to the binary compatibility test failure. This reverts #43 and adds:

  • a config file to ignore the interface change to prevent future test failures.
  • adds @internalapi annotations to the updated interfaces.

Fixes #19

skuruppu added 2 commits Jan 24, 2020
asyncClose() was added to com.google.cloud.spanner.Session and
asyncDeleteSession() was added to
com.google.cloud.spanner.spi.v1.SpannerRpc in #24 which resulted in
binary compatibility test failures. This config allows us to ignore the
failure.
@googlebot googlebot added the cla: yes label Jan 24, 2020
Users shouldn't be implementing these interfaces as they're internal to
the client library implementation.
@skuruppu skuruppu force-pushed the close-sessions-async-revert-revert branch from 9577f01 to da08183 Compare Jan 24, 2020
@skuruppu skuruppu changed the base branch from master to close-sessions-async Jan 24, 2020
@skuruppu skuruppu changed the base branch from close-sessions-async to master Jan 24, 2020
@skuruppu skuruppu requested a review from olavloite Jan 24, 2020
@olavloite olavloite merged commit c9864e5 into master Jan 24, 2020
11 checks passed
@olavloite olavloite deleted the close-sessions-async-revert-revert branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants