Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default retry settings for aborted transactions #48

Merged
merged 1 commit into from Jan 30, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jan 28, 2020

Aborted read/write transactions used static retry settings that were not coming from the gapic configuration. This PR changes that to using the default retry settings from the gapic configuration. As the default retry settings themselves are not accessible from the generated SpannerStubSettings class, the retry settings are taken from the configuration of the Rollback RPC, which is also linked with the default retry settings.

Updates #20

@googlebot googlebot added the cla: yes label Jan 28, 2020
@olavloite olavloite added the kokoro:force-run label Jan 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 28, 2020
@olavloite olavloite requested review from skuruppu and hengfengli Jan 28, 2020
Copy link
Contributor

@skuruppu skuruppu left a comment

Wow ok, that's an indirect way to get access to the settings but seems like this is the most reasonable way to do it.

@olavloite olavloite merged commit 6709552 into master Jan 30, 2020
11 checks passed
@olavloite olavloite deleted the issue-20-aborted-tx branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants