Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependency on commons-lang #494

Merged
merged 2 commits into from Oct 3, 2020
Merged

fix: remove dependency on commons-lang #494

merged 2 commits into from Oct 3, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Oct 2, 2020

@elharo elharo requested a review from thiagotnunes Oct 2, 2020
@elharo elharo requested review from as code owners Oct 2, 2020
@google-cla google-cla bot added the cla: yes label Oct 2, 2020
@elharo elharo changed the title remove dependency on commons-lang fix: remove dependency on commons-lang Oct 2, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 2, 2020

Codecov Report

Merging #494 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #494      +/-   ##
============================================
- Coverage     82.20%   82.19%   -0.02%     
+ Complexity     2468     2467       -1     
============================================
  Files           138      138              
  Lines         13643    13646       +3     
  Branches       1314     1314              
============================================
+ Hits          11215    11216       +1     
- Misses         1899     1901       +2     
  Partials        529      529              
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/spanner/connection/DdlBatch.java 85.85% <100.00%> (+0.44%) 28.00 <0.00> (ø)
.../google/cloud/spanner/SpannerExceptionFactory.java 71.79% <0.00%> (-2.57%) 33.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a95ef6...a98d722. Read the comment docs.

Copy link
Contributor

@olavloite olavloite left a comment

LGTM

@product-auto-label product-auto-label bot added the api: spanner label Oct 3, 2020
@elharo elharo merged commit c99294b into master Oct 3, 2020
18 of 19 checks passed
@elharo elharo deleted the commons branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants