feat!: remove session pool preparing #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## inline-begin-tx #515 +/- ##
=====================================================
- Coverage 82.31% 82.12% -0.19%
- Complexity 2419 2429 +10
=====================================================
Files 138 138
Lines 13518 13480 -38
Branches 1269 1299 +30
=====================================================
- Hits 11127 11071 -56
+ Misses 1885 1881 -4
- Partials 506 528 +22 Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: spanner
thiagotnunes
reviewed
Oct 18, 2020
| PooledSessionFuture session = | ||
| mode == SessionMode.READ_WRITE ? getReadWriteSession() : getReadSession(); | ||
| private <T> T runWithSessionRetry(Function<Session, T> callable) { | ||
| PooledSessionFuture session = getReadSession(); |
There was a problem hiding this comment.
nit: could we rename methods such as getReadSession() to getSession() now that we do not have such separation?
| @@ -36,9 +36,14 @@ | |||
| private static final LabelValue UNSET_LABEL = LabelValue.create(null); | |||
|
|
|||
| static final LabelValue NUM_IN_USE_SESSIONS = LabelValue.create("num_in_use_sessions"); | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
nit: could we add javadocs on the deprecation notice?
| } else { | ||
| span.addAnnotation("Acquired read only session"); | ||
| span.addAnnotation("Acquired rsession"); |
There was a problem hiding this comment.
nit: typo rsession -> session
| @@ -765,7 +762,7 @@ public void setSpan(Span span) { | |||
| new Callable<T>() { | |||
| @Override | |||
| public T call() { | |||
| boolean useInlinedBegin = inlineBegin; | |||
| boolean useInlinedBegin = true; | |||
| if (attempt.get() > 0) { | |||
| if (useInlinedBegin) { | |||
There was a problem hiding this comment.
Could we remove the branching here, since useInlinedBegin is always true?
There was a problem hiding this comment.
Yep, that's quite useless. Thanks for noticing.
thiagotnunes
approved these changes
Oct 21, 2020
thiagotnunes
pushed a commit
that referenced
this issue
Oct 23, 2020
* feat: inline begin tx with first statement * feat: support inlining BeginTransaction * fix: invalid dml statement can still return tx id * bench: add benchmarks for inline begin * feat: add inline begin for async runner * test: add additional tests and ITs * test: add tests for error during tx * test: use statement with same error code on emulator * test: skip test on emulator * test: constraint error causes transaction to be invalidated * fix: retry transaction if first statements fails and had BeginTransaction option * fix: handle aborted exceptions * test: add additional tests for corner cases * feat: use single-use tx for idem-potent mutations * fix: remove check for idempotent mutations * chore: remove commented code * feat!: remove session pool preparing (#515) * feat: remove session pool preparing * fix: fix integration tests * test: fix malformed retry loop in test case * fix: review comments * chore: run formatter * test: fix integration test that relied on data from other test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Removes the feature for preparing sessions in the session pool. This is step 2 of inlining
BeginTransactionwith the first statement of a transaction.